Version Packages #2299
Merged
Version Packages #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
02f8135
to
ba07845
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
6181707
to
427bf83
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
dc3e05b
to
1700c1b
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
1700c1b
to
de5e6ad
Compare
bruugey
approved these changes
Apr 15, 2024
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@leafygreen-ui/[email protected]
Major Changes
MenuonMenuItemclick. This behavior was causing issues with clickable items inside ofMenuItem. To control whenMenucloses, useopenandsetOpen. LG-4130@leafygreen-ui/[email protected]
Major Changes
cbfda91: LG-4144
FormFieldstyling changes apply toTextArea. See style changes hereA default
errorMessageof'This input needs your attention'will render below text area when state is invalid.A default
successMessageof'Success'will render when state is valid.successMessageprop accepts a custom string.Disabled
TextAreacomponent no longer renders thedisabledattribute and instead relies onaria-disabledandreadonlyattributes.The last change is made to ensure that disabled components are still focusable to users using keyboard navigation.
For more on
aria-disabledsee the documentation on MDNMigration guide
Functionally, migration should be seamless, however there may be unit/integration/e2e tests that relied on this behavior.
Jest/RTL
Generally, only this repo should need to test that these components have a specific attribute. We recommend updating unit tests to check that some event was or was not called.
However, there are cases where this may still need to be tested. In cases where a test checks
expect(textArea).toBeDisabled(), you can replace and use test harnesses.Cypress
Similar to unit tests, you should generally test functionality and not implementation details. However, to test this in Cypress replace any
cy.get(textArea).should('be.disabled');checks withcy.get(textArea).invoke('attr', 'aria-disabled').should('eq', 'true');Patch Changes
@leafygreen-ui/[email protected]
Major Changes
Linkcomponent so that:display: inline-flexTypographycomponent@lg-chat/[email protected]
Minor Changes
cbfda91: LG-4144
Updates spacing in
InlineMessageFeedbackcomponent due to updated styling inTextAreacomponentPatch Changes
@leafygreen-ui/[email protected]
Minor Changes
getTestUtils, a util to reliably interact withLG Buttonin a product test suite. For more details, check out the READMELGIDS_BUTTON, which storesdata-lgidvalues.@leafygreen-ui/[email protected]
Minor Changes
getTestUtils, a util to reliably interact withLG Checkboxin a product test suite. For more details, check out the READMELGIDS_CHECKBOX, which storesdata-lgidvalues.'aria-label'prop when passedPatch Changes
@leafygreen-ui/[email protected]
Minor Changes
ListSkeletoncomponentenableAnimationspropPatch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@lg-chat/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@leafygreen-ui/[email protected]
Patch Changes
@lg-tools/[email protected]
Patch Changes
@lg-tools/[email protected]
Patch Changes
data-lgidtostorybookExcludedControlParamsandstorybookExcludedArgTypes.